fix: return Unauthenticated instead of PermissionDenied on token expiration #5454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When JWT access tokens expire (after 15 minutes), API endpoints return
PermissionDeniedinstead ofUnauthenticated. This prevents the frontend's auth interceptor from triggering automatic token refresh, forcing users to manually refresh the page.Root Cause
Service methods checked
user == niland returnedcodes.PermissionDenied, but the frontend only catchescodes.Unauthenticatedto trigger token refresh via the refresh token cookie.Solution
Split authentication checks to distinguish:
Changes
idp_service.go: FixedCreateIdentityProvider,UpdateIdentityProvider,DeleteIdentityProviderinstance_service.go: FixedGetInstanceSettingstorage checkmemo_service.go: FixedGetMemovisibility checkuser_service.go: FixedUpdateUser,ListUserNotifications,UpdateUserNotification,DeleteUserNotificationTesting
401 → RefreshToken (200) → retry succeedsFixes #5448