fix: add SSRF protection to callback URL validation#96
Merged
user1303836 merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Block private, loopback, link-local, broadcast, and unspecified IPs in callback_url to prevent server-side request forgery. Also blocks 'localhost' hostname.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_private_ip()helper to detect loopback, private (10.x, 172.16.x, 192.168.x), link-local (169.254.x), broadcast, and unspecified IP addresses, plus IPv6 loopback/unspecified and thelocalhosthostnamevalidate_callback_url()to reject callback URLs targeting private/loopback addresses, preventing SSRF attackstest_validate_callback_url_loopback_rejected,test_validate_callback_url_localhost_rejected,test_validate_callback_url_private_ip_rejected,test_is_private_ip,test_ingest_with_loopback_callback_rejected) and update existing testAddresses review feedback from PR #90.