Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block movement support to sample editor #124

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add block movement support to sample editor #124

merged 1 commit into from
Aug 8, 2024

Conversation

amir9480
Copy link
Contributor

@amir9480 amir9480 commented Aug 8, 2024

This PR Adds move-up and move-down buttons to the sample editor

image

@cohitre
Copy link
Member

cohitre commented Aug 8, 2024 •
edited
Loading

Thanks, this is solid. I'll merge it shortly and follow up with a couple of additions:

  • remove the console.log
  • Add some adding around the TuneMenu
  • Disable the up/down arrow when on the edge.
  • re-select the block after the arrow is pressed.
  • we are careful with mutating the original document, but the moveChildrenId is mutating the childrenIds array directly.

@cohitre cohitre merged commit 029ca67 into usewaypoint:main Aug 8, 2024
1 check passed
@jordanisip jordanisip mentioned this pull request Aug 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cohitre cohitre cohitre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amir9480 @cohitre