[Outreachy Task Submission] Keyboard Accessibility: Improve UX of Sidebar (Focus Indicator use of semantic elements) #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Angamanga, I've completed the necessary updates for this PR and it's now awaiting review. @Ifycode, I wanted to bring your attention to this PR, which is connected to the one mentioned here. I've revisited it following some code refactoring in the sidebar. I would appreciate it if you could review the changes, particularly to assess any enhancements in implementation compared to the previous PR. |
Angamanga
approved these changes
Mar 27, 2024
I learnt from the best @Ifycode . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for issue
Fix:
The focus indicator has been improved for easier navigation of the sidebar using the keyboard. See the screenshot below.
Steps To Reproduce The Change
Environment:
Browsers: Chrome and Firefox