-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2e tests for survey configuration hide exact location information #997
Merged
AmTryingMyBest
merged 25 commits into
development
from
e2e-survey-configuration-hide-exact-location-information
May 10, 2024
Merged
E2e tests for survey configuration hide exact location information #997
AmTryingMyBest
merged 25 commits into
development
from
e2e-survey-configuration-hide-exact-location-information
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ient-mzima into e2e-survey-configuration-hide-exact-location-information
…ient-mzima into e2e-survey-configuration-hide-exact-location-information
…ient-mzima into e2e-survey-configuration-hide-exact-location-information
…ient-mzima into e2e-survey-configuration-hide-exact-location-information
…ient-mzima into e2e-survey-configuration-hide-exact-location-information
…ient-mzima into e2e-survey-configuration-hide-exact-location-information
AmTryingMyBest
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made several changes in this PR, but noteworthy is:
- instead of the screenshot plugin and comparing hidden location using a screenshot, i opted to use checking lat and long. values instead as done for the other configuration tests
…ient-mzima into e2e-survey-configuration-hide-exact-location-information
shakirandagire
force-pushed
the
e2e-survey-configuration-hide-exact-location-information
branch
from
May 7, 2024 06:48
f24ebc7
to
35ead2a
Compare
…ient-mzima into e2e-survey-configuration-hide-exact-location-information
…ocation-information
AmTryingMyBest
deleted the
e2e-survey-configuration-hide-exact-location-information
branch
May 10, 2024 08:24
AmTryingMyBest
restored the
e2e-survey-configuration-hide-exact-location-information
branch
May 10, 2024 09:22
tuxpiper
pushed a commit
that referenced
this pull request
May 10, 2024
) * Add e2e tests for survey configuration hide exact location information * Make change to the tests * Make changes to the test * Remove unnecessary changes * Update the locators and remove unnecessary content * Implement functionality of hidding location * Skip test for hidding post exact location information * Remove the traces of cypress-image-diff * Remove the test command I added * Remove the added command in e2e file * Remove the added command in e2e file * Update the locators that were showing null --------- Co-authored-by: Shakira <shakira@Shakiras-MacBook-Pro.local> Co-authored-by: AmTryingMyBest <38259840+AmTryingMyBest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AmTryingMyBest Could you review this PR for issue