Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2e tests for survey configuration hide exact location information #997

Conversation

shakirandagire
Copy link
Collaborator

@AmTryingMyBest Could you review this PR for issue

@shakirandagire shakirandagire marked this pull request as draft April 2, 2024 08:44
@shakirandagire shakirandagire marked this pull request as ready for review April 25, 2024 05:14
Copy link
Contributor

@AmTryingMyBest AmTryingMyBest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made several changes in this PR, but noteworthy is:

  • instead of the screenshot plugin and comparing hidden location using a screenshot, i opted to use checking lat and long. values instead as done for the other configuration tests

@shakirandagire shakirandagire force-pushed the e2e-survey-configuration-hide-exact-location-information branch from f24ebc7 to 35ead2a Compare May 7, 2024 06:48
@AmTryingMyBest AmTryingMyBest merged commit 3310c9b into development May 10, 2024
6 of 8 checks passed
@AmTryingMyBest AmTryingMyBest deleted the e2e-survey-configuration-hide-exact-location-information branch May 10, 2024 08:24
@AmTryingMyBest AmTryingMyBest restored the e2e-survey-configuration-hide-exact-location-information branch May 10, 2024 09:22
tuxpiper pushed a commit that referenced this pull request May 10, 2024
)

* Add e2e tests for survey configuration hide exact location information

* Make change to the tests

* Make changes to the test

* Remove unnecessary changes

* Update the locators and remove unnecessary content

* Implement functionality of hidding location

* Skip test for hidding post exact location information

* Remove the traces of cypress-image-diff

* Remove the test command I added

* Remove the added command in e2e file

* Remove the added command in e2e file

* Update the locators that were showing null

---------

Co-authored-by: Shakira <shakira@Shakiras-MacBook-Pro.local>
Co-authored-by: AmTryingMyBest <38259840+AmTryingMyBest@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants