Draft
Conversation
added 3 commits
March 10, 2022 10:40
In our current implementation of model-based theory combination, we need to make sure that two classes of interface variables do not collapse for our computed value of Simplex's delta. Lowering the max value should help to avoid deciding some pairs of classes explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes explicit the connection between the maximum delta value used in the Simplex model computation and the bound value that needs to be considered in model-based theory combination.
It also lowers this max value from
1(original) to1/2(new). This should result in less pairs of interface variables that need to be considered in UFLRA in order to get correct model.