Extended ScopedVector of clear and of accessing particular scopes#871
Open
Extended ScopedVector of clear and of accessing particular scopes#871
ScopedVector of clear and of accessing particular scopes#871Conversation
6ff949f to
043f56c
Compare
Member
|
Can you link to a proposed usage of the new functionality? |
Member
Author
|
I will most likely use it for the new feature of decision preferences, where I want to keep track of the processed frames in It is still a WIP, I do not even have a PR for it yet. The current version does not interfere with the preprocessing, which may be the reason why it is not working at the moment :) If the extension is too much, maybe we can make it a derived class? |
Member
Author
043f56c to
7ff93a4
Compare
7ff93a4 to
0fc9177
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended
ScopedVectorto allow more operations and look more std. container-like.Importantly, I added functions that allow accessing particular scopes, not only the entire vector, and not even necessarily the top scope. This allows traversing the elements in batches in a lazy fashion, as for example done with frames in the preprocessing pipeline.
Btw.,
AssertionStackcould probably also be rebased on top of aScopedVector, but it would not be that straightforward.