Skip to content

Comments

Extended ScopedVector of clear and of accessing particular scopes#871

Open
Tomaqa wants to merge 2 commits intomasterfrom
ext-scope-vector
Open

Extended ScopedVector of clear and of accessing particular scopes#871
Tomaqa wants to merge 2 commits intomasterfrom
ext-scope-vector

Conversation

@Tomaqa
Copy link
Member

@Tomaqa Tomaqa commented Oct 29, 2025

Extended ScopedVector to allow more operations and look more std. container-like.

Importantly, I added functions that allow accessing particular scopes, not only the entire vector, and not even necessarily the top scope. This allows traversing the elements in batches in a lazy fashion, as for example done with frames in the preprocessing pipeline.

Btw., AssertionStack could probably also be rebased on top of a ScopedVector, but it would not be that straightforward.

@Tomaqa Tomaqa force-pushed the ext-scope-vector branch 2 times, most recently from 6ff949f to 043f56c Compare October 29, 2025 10:04
@blishko
Copy link
Member

blishko commented Oct 29, 2025

Can you link to a proposed usage of the new functionality?

@Tomaqa
Copy link
Member Author

Tomaqa commented Oct 30, 2025

I will most likely use it for the new feature of decision preferences, where I want to keep track of the processed frames in simplifyFormulas, along with the preferences that are stored in a ScopedVector, because I will probably need to use the substituted formulas instead of the inserted ones and use their actual variables and clauses that are sent to the core solver.

It is still a WIP, I do not even have a PR for it yet. The current version does not interfere with the preprocessing, which may be the reason why it is not working at the moment :)

If the extension is too much, maybe we can make it a derived class?

@Tomaqa
Copy link
Member Author

Tomaqa commented Oct 30, 2025

#873 currently requires this PR + #872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants