Conversation
…ment - Replaced `max_processes` with `max_pids` and updated its description to clarify its role in preventing fork bombs. - Adjusted `max_processes` to reflect per-UID nproc ulimit, ensuring it is set high since `max_pids` manages per-container limits. - Added environment variable settings in `ContainerManager` to limit OpenBLAS/OpenMP threads, preventing nproc exhaustion. - Configured `pids_limit` in container settings to utilize the new `max_pids` value for enhanced process management.
…ement - Replaced `MAX_PROCESSES` with `MAX_PIDS` in configuration files to clarify its role in managing per-container process limits. - Updated `security-profiles.json` to reflect new `pidsLimit` values and removed deprecated `nproc` settings. - Adjusted documentation to include `MAX_PIDS` and its description, ensuring clarity on resource limits. - Cleaned up `ContainerManager` to remove references to `nproc`, focusing on `pids_limit` for enhanced process management.
…mpfs options - Replaced hardcoded values for `read_only` and `tmpfs` in `ContainerManager` with settings from the configuration to enhance flexibility and maintainability. - This change allows for easier adjustments to container settings without modifying the code directly.
- Added a new seccomp profile (`seccomp-sandbox.json`) to block dangerous syscalls, enhancing container security. - Updated `docker-compose.yml` to mount the seccomp profile into the container. - Modified configuration settings to allow specification of the seccomp profile path. - Enhanced `ContainerManager` to load and apply the seccomp profile during container creation. - Added integration tests to verify that the seccomp profile correctly blocks the `ptrace` syscall and that the profile file is valid.
…limits - Increased `MAX_EXECUTION_TIME` from 30 to 120 seconds in `.env.example` for extended processing capabilities. - Enabled `ENABLE_ORPHAN_MINIO_CLEANUP` in `.env.example` to allow periodic cleanup of orphaned MinIO objects. - Disabled documentation generation by setting `ENABLE_DOCS` to false in `.env.example`. - Added new integration tests in `test_file_handling.py` to validate the complete workflow of uploading, analyzing, and downloading CSV and JSON files, as well as processing images with OpenCV.
- Updated the configuration to replace `max_processes` with `max_pids` for clarity in managing per-container process limits.
- Added a comprehensive list of allowed file extensions for various categories including text, Microsoft Office, OpenDocument formats, data formats, images, web files, scripts, and archives to enhance file handling capabilities.
- Added `sanitize_filename` method in `OutputProcessor` to ensure filenames are safe for container use by replacing non-alphanumeric characters and handling edge cases. - Updated `upload_file` and `list_files` functions to utilize the new sanitization logic, ensuring consistent filename formatting across file operations. - Introduced unit tests for `sanitize_filename` to validate its functionality and edge case handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: