Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SST1RSoXSDB scan hinting breaks if a scanned axis has negative value #121

Closed
pbeaucage opened this issue Apr 2, 2024 · 0 comments · Fixed by #122
Closed

bug: SST1RSoXSDB scan hinting breaks if a scanned axis has negative value #121

pbeaucage opened this issue Apr 2, 2024 · 0 comments · Fixed by #122
Assignees

Comments

@pbeaucage
Copy link
Collaborator

SST1 RSoXS data doesn't include any hinting of what motor was scanned in an explicit way, so SST1RSoXSDB does a rather convoluted inspection process to figure out what motors moved significantly (as judged by the reduced standard deviation of the scan) and make only those motors dimensions of the resulting xarray. If a motor had negative values, due to a simple math bug, the reduced standard deviation is negative and the dimension isn't automatically hinted.

@pbeaucage pbeaucage self-assigned this Apr 2, 2024
pbeaucage added a commit that referenced this issue Apr 2, 2024
@pbeaucage pbeaucage linked a pull request Apr 2, 2024 that will close this issue
pdudenas added a commit that referenced this issue Apr 4, 2024
…ng-breaks-if-a-scanned-axis-has-negative-value

`SST1RSoXSDB`: fix bug described in  #121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant