SST1RSoXSDB: fix bug described in #121
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-scanned-axis-has-negative-value
…-scanned-axis-has-negative-value
…-scanned-axis-has-negative-value
pdudenas
approved these changes
Apr 4, 2024
pbeaucage
deleted the
121-bug-sst1rsoxsdb-scan-hinting-breaks-if-a-scanned-axis-has-negative-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See description in #121, this changes the dimension hinting code in the following ways:
instead of looking at
std(scan_values) / mean(scan_values)it now usesabs(std(scan_values)/(max(scan_values)-min(scan_values))time is now a default hinted dimension, so adds a kwarg that by default doesn't include it
there might be a few warning/other fixes that don't impact anything but API compatibility in this fix.
One question is whether tests should cover dimension hinting, i.e, that scan # 'x' is really energy/pol and 'y' is sam_x/sam_y. Just need test data on the public server for that.