Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI tests for sst1rsoxsdb loader #81

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

pbeaucage
Copy link
Collaborator

This PR adds a minimal set of CI tests for the SST1RSoXSDB loader; these tests were previously incompatible with GitHub Actions because the Tiled server that backs SST1RSoXSDB is only accessible from BNL networks. These tests are added and marked with pytest.mark.skipif() to only run on a system that has the tiled profile configured appropriately.

@pbeaucage pbeaucage linked an issue Apr 6, 2023 that may be closed by this pull request
@pbeaucage pbeaucage marked this pull request as ready for review April 11, 2023 14:55
Copy link
Collaborator

@BijalBPatel BijalBPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@BijalBPatel BijalBPatel merged commit 8e56991 into main Aug 3, 2023
26 checks passed
@pbeaucage pbeaucage deleted the 70-build-tests-for-sst1rsoxsdb-loader branch August 3, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build tests for SST1RSoXSDB loader
2 participants