-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
June 2024 in-progress merge #120
Merged
wendellpiez
merged 9 commits into
usnistgov:merge-June2024
from
wendellpiez:merge-June2024
Jun 11, 2024
Merged
June 2024 in-progress merge #120
wendellpiez
merged 9 commits into
usnistgov:merge-June2024
from
wendellpiez:merge-June2024
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several months of work building InspectorXSLT using test-driven-development. Also includes considerable work on XSpec support including XProc and Saxon runtimes, scripts and CI/CD support. --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
*** Many improvements to XSLTs and XSpec reporting scripts * Add permissions for EnricoMi/publish-unit-test-result-action Using the guidance from the action's instructions: https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches * Add artifact event pull for EnricoMi/publish-unit-test-result-action Using the guidance from the action's instructions: https://github.com/EnricoMi/publish-unit-test-result-action?tab=readme-ov-file#support-fork-repositories-and-dependabot-branches * Ensure XSpec test results comment always made on PR * [WIP] Dedupe event trigger and inline JUnit XML processing in CI workflow --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
…gov#73) Several months of work building InspectorXSLT using test-driven-development. Also includes considerable work on XSpec support including XProc and Saxon runtimes, scripts and CI/CD support. --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
aj-stein-nist
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor feedback and difference of opinion I will couch with "your codebase, your rules," so I approve anyway.
src/schema-gen/InspectorXSLT/testing/current/tiny_metaschema_COMPOSED-metaschema.xml
Outdated
Show resolved
Hide resolved
src/schema-gen/InspectorXSLT/testing/generate-oscal-catalog-inspector.sh
Outdated
Show resolved
Hide resolved
src/schema-gen/InspectorXSLT/testing/current/computer_inspector.xsl
Outdated
Show resolved
Hide resolved
src/schema-gen/InspectorXSLT/testing/current/computer_metaschema-xmlschema.xsd
Outdated
Show resolved
Hide resolved
src/schema-gen/InspectorXSLT/testing/current/tiny_inspector.xsl
Outdated
Show resolved
Hide resolved
src/schema-gen/InspectorXSLT/testing/current/tiny_metaschema-xmlschema.xsd
Outdated
Show resolved
Hide resolved
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
…spector.sh Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
wendellpiez
added a commit
that referenced
this pull request
Aug 30, 2024
* produce-xml-converter.xsl: XSpec tests and minor XSLT improvements (#87) * XSpec tests and minor XSLT improvements * JSON Schema generation improvements (#108) Refactoring submodules; XProc-based testing; XSpec testing of JSON Schema generation; improvements to JSON Schema generation - addressing #105 also #2007. * June 2024 Integration (#118) Integrating branches * June 2024 in-progress merge (#120) Includes updates to unit testing, Inspector XSLT, JSON Schema (#105) and others * More testing (#122) Mostly testing support - * Adding Makefile in compose phase to run XSpec - presently showing errors! * Extending and reorganizing testing, including removing temporary artifacts from git * Adding subpipeline mistakenly omitted from the last PR * New Makefile for testing/tinydata * Mending XSpecs testing Metaschema composition (regression protection); also a new tinydata sample. * Update src/testing/tinydata/tiny-data/terms-of-art.xml (AJ Stein) Co-authored-by: Wendell Piez <wendell.piez@nist.gov> Co-authored-by: Amanda Galtman <40716346+galtm@users.noreply.github.com> Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Last alignment of several PRs merging?
This PR adds new copies of resources and makes a couple of small updates. After merging, we can drop this WIP branch and start another one targeting the merge branch.
All Submissions:
Changes to Core Features: