Skip to content

Commit

Permalink
feat: sort meta by name in asc order (#57)
Browse files Browse the repository at this point in the history
Signed-off-by: Jian Zeng <anonymousknight96@gmail.com>
  • Loading branch information
knight42 authored Jan 28, 2024
1 parent baf51b9 commit 3bc682f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/server/meta_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func (s *Server) handlerListRepoMetas(c echo.Context) error {
l.Debug("Invoked")

var metas []model.RepoMeta
err := s.getDB(c).Find(&metas).Error
err := s.getDB(c).Order("name").Find(&metas).Error
if err != nil {
const msg = "Fail to list RepoMetas"
l.Error(msg, slogErrAttr(err))
Expand Down
9 changes: 6 additions & 3 deletions pkg/server/meta_handlers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ func TestHandlerListRepoMetas(t *testing.T) {
te := NewTestEnv(t)
require.NoError(t, te.server.db.Create([]model.RepoMeta{
{
Name: t.Name(),
Name: "repo2",
},
{
Name: "repo1",
},
}).Error)

Expand All @@ -23,8 +26,8 @@ func TestHandlerListRepoMetas(t *testing.T) {
require.NoError(t, err)
require.True(t, resp.IsSuccess(), "Unexpected response: %s", resp.Body())

require.Len(t, metas, 1)
require.EqualValues(t, t.Name(), metas[0].Name)
require.Len(t, metas, 2)
require.EqualValues(t, "repo1", metas[0].Name)
}

func TestHandlerGetRepoMeta(t *testing.T) {
Expand Down

0 comments on commit 3bc682f

Please sign in to comment.