Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Improve Error Messages and Recovery Suggestions #44

Merged
2 commits merged into from
Feb 20, 2017
Merged

Improve Error Messages and Recovery Suggestions #44

2 commits merged into from
Feb 20, 2017

Commits on Feb 20, 2017

  1. Improve error messages and recovery suggestions

    Resolves #35 `Improve Error Explanation for Rate Limit`.
    
    - Adds checks for rate limiting and uses new, specific error
    - Refactors response validation to static methods in an extension of
    `ResponseHandler`, thus providing a default implementation to all
    response handlers
    - Refactors the deserialisation of JSON in `JSONResponseHandler` into a
    separate method to improve readability
    - Updates `GitHubScannerProtocolError` to inherit from `LocalizedError`
    and provides a default implementation for `CustomStringConvertible`
    - Adds `errorDescription` and `recoverySuggestion` to all error types
    - Moves `NetworkError` and `ScanOptionsError` into own files
    - Expands test suite for error handling
    - Refactors accessing the `HTTPURLResponse` next link header into an
    extension property to improve readability of `JSONResponseHandler` and
    to help maintain single responsibility principle
    Aaron McTavish committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    2ce0784 View commit details
    Browse the repository at this point in the history
  2. Fix indendentation of if statement

    Per code review by @arnau
    Aaron McTavish committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    2847e89 View commit details
    Browse the repository at this point in the history