-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cmcc dns #436
Open
hujingnb
wants to merge
1
commit into
usual2970:next
Choose a base branch
from
hujingnb:feat/cmcc
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add cmcc dns #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hujingnb
force-pushed
the
feat/cmcc
branch
2 times, most recently
from
January 30, 2025 11:45
eb1eb31
to
b30a1b8
Compare
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
internal/pkg/core/applicant/acme-dns-01/lego-providers/cmcc/lego.go
Outdated
Show resolved
Hide resolved
fudiwei
added
enhancement
New feature or request
help wanted
Extra attention is needed
invalid
This doesn't seem right
labels
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
fudiwei
reviewed
Jan 30, 2025
@hujingnb 感谢贡献代码,这个 PR 需要做出一些调整,麻烦根据批注修改一下。 新年快乐~ 😀 |
hujingnb
force-pushed
the
feat/cmcc
branch
2 times, most recently
from
January 30, 2025 16:01
8257276
to
e1decb2
Compare
已处理. 感谢审核, 新年快乐 |
fudiwei
reviewed
Jan 31, 2025
internal/pkg/core/applicant/acme-dns-01/lego-providers/cmcc/cmcc.go
Outdated
Show resolved
Hide resolved
hujingnb
force-pushed
the
feat/cmcc
branch
2 times, most recently
from
January 31, 2025 11:01
9f123c6
to
6505e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
help wanted
Extra attention is needed
invalid
This doesn't seem right
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #79
test: