Upgrade Go v1.17 -> v1.25.5 & migrate CI #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Holden <john.holden@rvu.co.uk>
John-Holden
changed the title
mmcgarr
reviewed
Jan 13, 2026
.github/workflows/ci.yml
Outdated
Comment on lines
27
to
28
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 |
There was a problem hiding this comment.
Was this needed? I think normally buildx is needed if we're building for multiple platforms and things. Not sure that's the case here
mmcgarr
reviewed
Jan 13, 2026
.github/workflows/ci.yml
Outdated
| # For tags: tag with the git tag | ||
| type=ref,event=tag | ||
| # For master branch: also tag as latest | ||
| type=raw,value=latest,enable=${{ github.ref == 'refs/heads/master' }} |
There was a problem hiding this comment.
I think the latest tag will be added automatically here for builds on the master branch without needing this
mmcgarr
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.