Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] SetValueの修正 #14

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

TomokiMochizuki
Copy link
Member

@TomokiMochizuki TomokiMochizuki commented Feb 6, 2023

概要

[hotfix] SetValueの修正

Issue

  • N/A

詳細

  • SetTelemetryValuesAsyncにおいて,TypeTlmLenCheck(tlm.TelemetryInfo.Type, tlm.TelemetryInfo.BitLen)がfalseの時にテレメの値をUInt16UInt32に変換する箇所が誤っているため修正.

@meltingrabbit
Copy link
Collaborator

めっちゃ助かる!今確認します

@meltingrabbit
Copy link
Collaborator

@TomokiMochizuki ありがとう!
u16のはなおってそう(=APIDは正しい)

このケースがだめなんだけど,わかりますか?

TLM1 uint32_t PACKET 81 0 24 NONE
TLM2 (セル結合) PACKET 81 24 8 NONE

試しに,
0x48494A4B
を流すと,本来は

TLM1 = 0x48494A
TLM2 = 0x4B
となるはずが

TLM1 = 0x48
TLM2 = 0

となってしまいました.

@TomokiMochizuki TomokiMochizuki changed the title [hotfix] SetTelemetryValuesAsyncの修正 [hotfix] SetValueの修正 Feb 6, 2023
@meltingrabbit
Copy link
Collaborator

meltingrabbit commented Feb 6, 2023

ひとまず治ってそう!!!ありがとう

image

image

下のブロックは正常なんだけど,上はDUMMY01が0になってしまってそう

@TomokiMochizuki

@meltingrabbit
Copy link
Collaborator

まあどうなんだろう.これでもいいのかな.
なんか,テレメ圧縮という文脈では,セル結合したさあるけど,わざわざしなくてもいい??

@meltingrabbit
Copy link
Collaborator

bitpos を 8 以上 を認めるかどうか,って感じか~~~

@TomokiMochizuki
Copy link
Member Author

セル結合してもそこまで処理がめんどくさくなるわけではないので,あってもいいと思います!

@meltingrabbit
Copy link
Collaborator

OK!

@meltingrabbit
Copy link
Collaborator

bitpos も bitlenも 0 ~ 31 を考慮する感じか

@TomokiMochizuki TomokiMochizuki force-pushed the hotfix/fix_tmPacketAnalyzerBase branch from 632b2e6 to e49df29 Compare February 6, 2023 14:28
@meltingrabbit
Copy link
Collaborator

では検証します

@meltingrabbit
Copy link
Collaborator

@TomokiMochizuki あれ?
これなおってる?

#14 (comment)

@meltingrabbit
Copy link
Collaborator

SQLとか消さないと行けないやつだっけ?(image buildもキャッシュ消さないとだめなやつだっけ?)

@TomokiMochizuki TomokiMochizuki force-pushed the hotfix/fix_tmPacketAnalyzerBase branch from ee6f21c to 0db3ef0 Compare February 6, 2023 15:12
@TomokiMochizuki
Copy link
Member Author

SQLとか消さないと行けないやつだっけ?(image buildもキャッシュ消さないとだめなやつだっけ?)

SQLはいじってないのでしなくていいと思います

@TomokiMochizuki TomokiMochizuki force-pushed the hotfix/fix_tmPacketAnalyzerBase branch 2 times, most recently from dbcbd2b to 055c06b Compare February 7, 2023 01:45
@TomokiMochizuki
Copy link
Member Author

Copy link
Collaborator

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お疲れ様

@TomokiMochizuki TomokiMochizuki merged commit 3c401e4 into develop Feb 7, 2023
@TomokiMochizuki TomokiMochizuki deleted the hotfix/fix_tmPacketAnalyzerBase branch February 7, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants