Add cache fallback into DB library #494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogelito
reviewed
Dec 17, 2024
abnegate
reviewed
Jan 13, 2025
abnegate
reviewed
Jan 13, 2025
# Conflicts: # composer.lock # tests/e2e/Adapter/Base.php
abnegate
reviewed
Jan 21, 2025
Member
abnegate
left a comment
abnegate
left a comment
There was a problem hiding this comment.
We need to re-target to main and get the tests passing
# Conflicts: # src/Database/Database.php
abnegate
reviewed
Feb 4, 2025
abnegate
reviewed
Feb 4, 2025
abnegate
reviewed
Feb 4, 2025
abnegate
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces exception catches for when a DB cache fails and makes it so we automatically falls back to not using the cache, this PR currently uses
Console::warningas a way to emit these failure mainly because getting rid of them entirely could result in performance degradation not being noticed because of caches being down.Tests have been added to check these changes work and checks will also be added into Appwrite