Skip to content

Fix parameter name for v6 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abnegate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix parameter name for v6 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
},
"require": {
"php": ">=8.0",
"ext-swoole": "*",
"ext-swoole": "6.*",
Copy link

@coderabbitai coderabbitai bot Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Align PHP engine constraint with Swoole 6 minimum (>= 8.1)

Swoole 6.x requires PHP >= 8.1. Keeping "php": ">=8.0" allows installing this package on platforms that cannot satisfy ext-swoole:6.*, leading to confusing Composer resolution failures. Bump the PHP requirement to be explicit.

Apply this diff:

-        "php": ">=8.0",
+        "php": ">=8.1",

References: Swoole 6.0.2 requires PHP >= 8.1 (Packagist/PECL). (packagist.org, pecl.php.net)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"ext-swoole": "6.*",
"php": ">=8.1",
"ext-swoole": "6.*",
🤖 Prompt for AI Agents 
In composer.json around line 17, the package requires "ext-swoole": "6.*" but
the project PHP engine constraint is still ">=8.0"; change the "php" requirement
to ">=8.1" to match Swoole 6's minimum PHP version, then run composer validate
and update the lockfile (e.g., composer update --lock or composer update) to
ensure composer.lock reflects the new PHP constraint.

"utopia-php/framework": "0.33.*"
},
"require-dev": {
"phpunit/phpunit": "^9.3",
"swoole/ide-helper": "5.0.2",
"swoole/ide-helper": "6.0.2",
"laravel/pint": "1.2.*",
"phpstan/phpstan": "^1.10"
},
Expand Down
Loading
Loading