Merge pull request #9 from utopia-php/refactor-vcs-tests

Add tests for create and delete repos
utopia-php · Oct 19, 2023 · d161d11 · d161d11
2 parents be86617 + c293d06
commit d161d11
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/src/VCS/Adapter.php b/src/VCS/Adapter.php
@@ -116,7 +116,7 @@ abstract public function createRepository(string $owner, string $repositoryName,
     /**
      * Delete repository
      */
-    abstract public function deleteRepository(string $owner, string $repositoryName): void;
+    abstract public function deleteRepository(string $owner, string $repositoryName): bool;
 
     /**
      * Get latest opened pull request with specific base branch

diff --git a/src/VCS/Adapter/Git/GitHub.php b/src/VCS/Adapter/Git/GitHub.php
@@ -192,11 +192,18 @@ public function listRepositoryContents(string $owner, string $repositoryName, st
         }, $response['body']);
     }
 
-    public function deleteRepository(string $owner, string $repositoryName): void
+    public function deleteRepository(string $owner, string $repositoryName): bool
     {
         $url = "/repos/{$owner}/{$repositoryName}";
 
-        $this->call(self::METHOD_DELETE, $url, ['Authorization' => "Bearer $this->accessToken"]);
+        $response = $this->call(self::METHOD_DELETE, $url, ['Authorization' => "Bearer $this->accessToken"]);
+
+        $statusCode = $response['headers']['status-code'];
+
+        if ($statusCode >= 400) {
+            throw new Exception("Deleting repository $repositoryName failed with status code $statusCode");
+        }
+        return true;
     }
 
     /**

diff --git a/tests/VCS/Base.php b/tests/VCS/Base.php
@@ -2,6 +2,7 @@
 
 namespace Utopia\Tests;
 
+use Exception;
 use PHPUnit\Framework\TestCase;
 use Utopia\App;
 use Utopia\VCS\Adapter\Git;
@@ -81,4 +82,22 @@ public function testListRepositoryContents(): void
         $this->assertIsArray($contents);
         $this->assertNotEmpty($contents);
     }
+
+    public function testCreateRepository(): void
+    {
+        $repository = $this->vcsAdapter->createRepository('test-kh', 'new-repo', true);
+        $this->assertIsArray($repository);
+        $this->assertEquals('test-kh/new-repo', $repository['full_name']);
+    }
+
+    /**
+     * @depends testCreateRepository
+     */
+    public function testDeleteRepository(): void
+    {
+        $result = $this->vcsAdapter->deleteRepository('test-kh', 'new-repo');
+        $this->assertEquals(true, $result);
+        $this->expectException(Exception::class);
+        $result = $this->vcsAdapter->deleteRepository('test-kh', 'new-repo-2');
+    }
 }