Merge pull request #10 from utopia-php/fix-array-null

Add array check for listRepoContents when it's Not Found
utopia-php · Nov 8, 2023 · f135291 · f135291
2 parents 40449d8 + 01ca4c2
commit f135291
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 14 deletions.
diff --git a/composer.lock b/composer.lock
diff --git a/src/VCS/Adapter/Git/GitHub.php b/src/VCS/Adapter/Git/GitHub.php
@@ -187,6 +187,10 @@ public function listRepositoryContents(string $owner, string $repositoryName, st
 
         $response = $this->call(self::METHOD_GET, $url, ['Authorization' => "Bearer $this->accessToken"]);
 
+        if (($response['headers']['status-code'] == 404)) {
+            return [];
+        }
+
         return array_map(static function ($item) {
             return $item['name'];
         }, $response['body']);

diff --git a/tests/Detector/DetectorTest.php b/tests/Detector/DetectorTest.php
@@ -61,6 +61,7 @@ public function setUp(): void
 
     public function testLanguageDetection(): void
     {
+        // test for SUCCESS
         $languageMap = [
             ['vermakhushboo', 'basic-js-crud', 'node'],
             ['appwrite', 'appwrite', 'php'],
@@ -82,5 +83,11 @@ public function testLanguageDetection(): void
             $runtime = $this->detect($files, $languages);
             $this->assertEquals($expectedRuntime, $runtime);
         }
+
+        // test for FAILURE
+        $files = $this->github->listRepositoryContents('', '');
+        $languages = $this->github->listRepositoryLanguages('', '');
+        $runtime = $this->detect($files, $languages);
+        $this->assertEquals(null, $runtime);
     }
 }