Fix node notifications and positions #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
force-pushed
the
fix/position
branch
from
a6ef186
to
fd3f703
Compare
piiertho
approved these changes
Feb 13, 2024
CedNaru
force-pushed
the
fix/position
branch
from
fd3f703
to
d005ceb
Compare
CedNaru
force-pushed
the
fix/position
branch
from
d005ceb
to
79feb8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that functions like
_enter_tree() or_process()in gdextension are overridden by regular scripts.When it's the case, the C++ code we wrote for nodes was no longer executed, leading to their positions no longer updated.
I no longer override those usual lifecycle callbacks anymore and rely on notifications instead.
_notification()is safe to override, Godot treats this method as a special case and call all implementations across native objects, extensions and scripts.