wire, netsync: change MsgUtreexoTx serialization #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added for utility but mainly to check that if the LeafData has been initialized or not. Makes it easy to tell if the txIn this LeafData represents is confirmed or unconfirmed.
unconfirmed marker in the TxIn.OutPoint.Index Instead of having the UData wrapper, MsgUtreexoTx has the BatchProof and the LeafData structs directly. Also, confirmed marker for each TxIn is now included in its OutPoint.Index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest change made here is to do
PreviousOutPoint.Index <<= 1and use the LSB to indicate if theTxIn is confirmed or not. This is mainly done to give ordering to the LeafDatas and the TxIns. Without
this, it's hard to tell which LeafData is for which TxIn.