blockchain, main, wire, indexers: change MsgUtreexoTx serialization #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for reconstructing a single leaf is refactored out into a separate function so it can be re-used by other callers.
ReconstructLeafDatas reconstructs the leafdatas based on the given TxIns. Handy for callers outside the blockchain package.
Reduce the duplicate code by calling ReconstructLeafDatas from VerifyUData.
relayUtreexoTx is changed to generate leafhashes by reconstructing compact udatas instead of just erroring out and failing. This has resulted in utreexo nodes not seeing the entire mempool which is fixed in this commit.
Skip the serialization of unconfirmed txIns to save on bandwidth.
Since some leaves are just there to indicate that txIns are unconfirmed, they are not able to be hashed. We skip over these leaves with this commit.
The unconfirmed leafdatas were being hashed which resulted in the verification failing since that leafhash doesn't exist in the accumulator. This commit addresses that.
Utreexo txs get put into the orphan pool but since the udata is no longer included in the tx, we need to keep track of it separately. This commit addresses that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest changes:
1: MsgUtreexoTx now includes the LeafDatas and the Proof directly instead of having UData as a field.
2: Each TxIn's OutPoint.Index now also encodes if the OutPoint being addressed is confirmed or not.
3: The count of the LeafData is no longer written. The count is implied by the len(TxIn) and if each LeafData is confirmed or not.
4: Various code changes to account for the fact that there's LeafDatas that are for unconfirmed TxIns exist within the slice of LeafDatas.