Merged
Conversation
Introduces a GetTimeout method to MongoClient for retrieving the configured timeout duration. Also adds a comment to the Ping method for clarity.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull Request: feature/get-timeout-from-db-client
Description
This pull request introduces a new method to the
MongoClientclass that allows retrieval of the timeout duration configured for the MongoDB client. The following changes are made to enhance the functionality of the database client:Addition of
GetTimeoutMethod:GetTimeout, is added to theMongoClientclass. This method returns the timeout duration for the MongoDB client in milliseconds, providing a straightforward way to access this configuration.Documentation Updates:
PingandGetTimeoutmethods to improve code readability and maintainability.Motivation
The primary motivation behind this change is to improve the configurability and introspection capabilities of the MongoDB client within our project. By exposing the timeout configuration, developers can better understand and manage the database client's behavior, particularly in scenarios involving network latency and server responsiveness.
Benefits
Overall, this change improves the project's robustness and maintainability by providing essential insights into the database client's configuration.