Conversation
Add Count(ctx, db, collection, filter, opts...) to DatabaseInterface and implement it for MongoClient and MockDatabase. MongoClient.Count uses Collection.CountDocuments and supports *moptions.CountOptions from opts. MockDatabase is extended with CountFunc, CountQueue, CountCalls, CountResponse and CountCall types, a Count method, ExpectCount and QueueCount helpers, initialization and Reset updates, and comprehensive tests covering default behavior, queued responses, custom CountFunc, errors, and reset behavior.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
The database abstraction was missing a first‑class way to count documents, forcing callers to either overuse
Find/FindOneor reach into database‑specific APIs. This made common use cases (pagination, existence checks, metrics) more awkward and less testable.Why this improves the project
Countoperation that matches real application needs.Overall, this makes the database layer more complete, easier to test, and more aligned with how it’s actually used.