Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signup page prompt text and adding new onsite contacts on small screens #174

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

ColinToft
Copy link
Collaborator

Implementation Description

  • Fixed some magic numbers for maximum number of rows in onsite contacts
  • Hopefully made onsite contacts work in mobile
  • Changed the placeholder text to say "Address and city" instead of just address

Steps To Test

  1. Try signing up on mobile (should work now)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have added tests for my changes
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

github-actions bot commented Sep 3, 2024

Visit the preview URL for this PR (updated for commit 6fa3913):

https://feeding-canadian-kids-staging--pr174-signup-page-mobil-y8iy96gp.web.app

(expires Tue, 10 Sep 2024 03:31:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f3744353be12c99e3df04fa4e0f28b3ad46bf004

@shahanneda shahanneda merged commit 5941bb7 into main Sep 4, 2024
4 checks passed
@shahanneda shahanneda deleted the signup-page-mobile branch September 4, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants