Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Persist data from Personal Info in Available Sessions Page #292

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

NathanSouphanthong
Copy link
Contributor

Notion ticket link

Registration: Existing registration details don’t persist if a parent returns from session selection

Implementation description

  • Move the useState initialization of the RegistrantExperienceCamper array to the RegistrantExperience page instead of inside the RegistrationSteps page
  • Pass the state and setter into the RegistrationSteps component

Steps to test

  1. Navigate to the registration page for a camp
  2. Fill out all the info for Step 1 - Personal Info
  3. Click the next button
  4. Go back twice to the Available Session page
  5. The Personal Info data that was filled out should persist

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@NathanSouphanthong NathanSouphanthong temporarily deployed to fon-preview July 29, 2023 19:49 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jul 29, 2023

Visit the preview URL for this PR (updated for commit c28018b):

https://focus-on-nature--pr292-nathan-existing-regi-w0611xrj.web.app

(expires Sat, 12 Aug 2023 20:22:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0aeb3dd1cc2aa82265739c366a8befd0d956fd1f

Copy link
Contributor

@williamtran10 williamtran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we add these changes to the waitlist registration too?

@NathanSouphanthong NathanSouphanthong temporarily deployed to fon-preview August 5, 2023 19:41 — with GitHub Actions Inactive
@NathanSouphanthong
Copy link
Contributor Author

LGTM. Should we add these changes to the waitlist registration too?

Good catch. Just added the changes to the Waitlist Registration 👍

@NathanSouphanthong NathanSouphanthong temporarily deployed to fon-preview August 5, 2023 20:18 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants