Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove completed request deletion #386

Merged
merged 1 commit into from
Jan 26, 2025
Merged

[Improvement] Remove completed request deletion #386

merged 1 commit into from
Jan 26, 2025

Conversation

ChinemeremChigbo
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo commented Dec 10, 2024 •
edited
Loading

Notion ticket link

Modify user deletion in requests page

Implementation description

  • I removed the option to delete a request that has been completed.

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@ChinemeremChigbo ChinemeremChigbo force-pushed the remove-completed-request-deletion branch from 9d3faad to e7c3ff1 Compare December 10, 2024 03:12
@ChinemeremChigbo ChinemeremChigbo force-pushed the remove-completed-request-deletion branch from e7c3ff1 to 3de18be Compare December 10, 2024 03:32
@ChinemeremChigbo ChinemeremChigbo changed the title Remove completed request deletion [Improvement] Remove completed request deletion Dec 10, 2024
@ChinemeremChigbo ChinemeremChigbo merged commit 398bbdd into staging Jan 26, 2025
1 check passed
@ChinemeremChigbo ChinemeremChigbo deleted the remove-completed-request-deletion branch January 26, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryhli sherryhli sherryhli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChinemeremChigbo @sherryhli