Create buildings table

[helenellyx]

Helen's PR

GitHub Issue link

Create Buildings Table

Implementation description

• Create Buildings table
• Update the Residents and Log_records table to have building_id as a foreign key for the buildings table
• Update the Residents and Log_records APIs to reflect this change
• Add the three buildings on the SHOW website to the Buildings table whenever we initialize the database

Steps to test

1. Check that Buildings table has the three building instances
2. Check that Residents API still works (please refer to the notion docs)
3. Check that Log_records API still works (please refer to the notion docs)

What should reviewers focus on?

• preexisting API

Kelly's Edits

• on backend, fixed apis to return building_id instead of building
• in frontend, fixed API calls to use building_id instead of building
• fixed adding, editing, filtering, counting log records to have parameter of building_id
• fixed adding and editing resident to have parameter of building_id
• edit existing scripts and added new one to create buildings

Steps to test

1. Drop your database and create it again (so you can get the new buildings table)
2. Run the scripts in repo read.me AND this new script bash ./seeding/create-buildings.sh
3. Add residents
4. Edit residents
5. Filter log records
6. Add log records
7. Edit log records

What should reviewers focus on?

• check functionality
• check if script works

Checklist

• My PR name is descriptive and in imperative tense
• My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
• I have run the appropriate linter(s)
• I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
• If I have made API changes, I have updated the REST API Docs
• IF I have made changes to the db/models, I have updated the Data Models Page
• I have updated other Docs as needed

[Safewaan]

still need to review the API changes but putting up review for the pre-population of building data

[Safewaan]

LGTM 🔥

There are 2 changes you need to make to the GET service for log_records, but other than that everything looks correct :D

Before merging, I would also just double-check that all changes services are working correctly.

[phamkelly17]

yas queen helen slay lgtm asf girlypop

[github-actions]

Visit the preview URL for this PR (updated for commit 0e9f68c):

https://blueprintsupportivehousing--pr125-helen-create-buildin-yw22mu1h.web.app

_{(expires Sun, 12 Nov 2023 19:30:45 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09}

[phamkelly17]

JK SO MANY THINGS ARE BROKEN... I'm working on it...

[phamkelly17]

idk why i just approved my own pr lol

[phamkelly17]

some things I noticed while doing this PR (future tickets):

1. we hardcode BUILDINGS in front but do we want an API route to get all buildings? If so, need to make those endpoints
2. in this PR, i tried to make it consistent and use building_id instead of building (which is a string). For example, LogRecords now have a building_id field instead of a building field. As a result, we don't readily have access to the building names.

so for example, this column in the table only has the resident building id instead of the building name. similar issue for the CSV so we'll have to address those. I think that we should be storing `building_id` in the tables but lmk what you guys think.

[connor-bechthold]

sorry for the amount of comments 😅 helen was defo plotting so thanks for cleaning this up!!

with regards to your comments

• you're right, we'll need a GET endpoint for getting all the buildings from the DB, but that can be done in a separate ticket
• leaving as displaying the ID in the residents table is fine for now, but all we need to do is also get the building name when we're fetching a resident (similar to what we do when we're getting log records). however this can also be done in a separate ticket, and is apart of the reason why i want you to set up those relationship columns in the models

[connor-bechthold]

whoops running the linter blew the number of files changed but this is GOOD TO GO 🧑‍🍳