Fixed some typescript errors #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rajsite
added a commit
to ni/nimble
that referenced
this pull request
Mar 25, 2024
# Pull Request ## 🤨 Rationale I tried to expand on the strategy switching mechanism from the renderer, and reused it in the coordinator This approach has the benefits of isolating the experimental code while in development, and an easy way to switch to the new version by changing just the imports and switching mechanism and removing the old versions after they become obsolete ## 👩💻 Implementation because arquero causes typescript errors I implemented an alternative search and posted a PR with fixes in arquero repo uwdata/arquero#346 changed the zoom handler to catch events on the component, not just the canvas removed zooming border of around 100px when zooming in the wafer after PO decision, resulting in less complex code and touch controls enabling. ## 🧪 Testing existing tests are passing created new hover unit tests with wafer and data manager mocks ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: rajsite <rajsite@users.noreply.github.com>
11 tasks
|
Thank you! I appreciate all the work you've done here. The Arquero v6.0.0 updates (#358) include changes to improve TypeScript use, including explicit tests to check for TypeScript errors. So I'm closing out this PR in lieu of those updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am researching the use of arquero in https://github.com/ni/nimble but installing the package will trigger some typescript errors when building.
I would like to not skip the lib check so I made some type fixes here.
Quite a few of them were too complex for me so I just marked them with
// @ts-ignore.Please let me know if you think there is a negative impact so I can update the changes.