Fix Sonar issues

uweseimet · Dec 11, 2023 · 0033092 · 0033092
1 parent 4271f3b
commit 0033092
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/cpp/buses/rpi_bus.cpp b/cpp/buses/rpi_bus.cpp
@@ -531,12 +531,12 @@ bool RpiBus::GetREQ() const
     return GetSignal(PIN_REQ);
 }
 
-void RpiBus::SetREQ(bool ast)
+inline void RpiBus::SetREQ(bool ast)
 {
     SetSignal(PIN_REQ, ast);
 }
 
-uint8_t RpiBus::GetDAT()
+inline uint8_t RpiBus::GetDAT()
 {
     return static_cast<uint8_t>(Acquire() >> PIN_DT0);
 }

diff --git a/cpp/buses/rpi_bus.h b/cpp/buses/rpi_bus.h
@@ -95,10 +95,10 @@ class RpiBus : public GpioBus
     void SetIO(bool ast) override;
 
     bool GetREQ() const override;
-    inline void SetREQ(bool ast) override;
+    void SetREQ(bool ast) override;
 
-    inline uint8_t GetDAT() override;
-    inline void SetDAT(uint8_t) override;
+    uint8_t GetDAT() override;
+    void SetDAT(uint8_t) override;
 
     bool WaitREQ(bool ast) override
     {
@@ -150,16 +150,16 @@ class RpiBus : public GpioBus
 
 #ifndef NO_IRQ_DISABLE
     // Interrupt enabled state
-    volatile uint32_t irptenb; // NOSONAR volatile needed for register access
+    volatile uint32_t irptenb;
 
     // Interupt control target CPU
-    volatile int tintcore; // NOSONAR volatile needed for register access
+    volatile int tintcore;
 
     // Interupt control
-    volatile uint32_t tintctl; // NOSONAR volatile needed for register access
+    volatile uint32_t tintctl;
 
     // GICC priority setting
-    volatile uint32_t giccpmr; // NOSONAR volatile needed for register access
+    volatile uint32_t giccpmr;
 #endif
 
     // GIC Interrupt distributor register