Skip to content

Commit

Permalink
Remove obsolete code
Browse files Browse the repository at this point in the history
  • Loading branch information
uweseimet committed Feb 2, 2024
1 parent 5a99fcb commit 790ca34
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 32 deletions.
32 changes: 1 addition & 31 deletions cpp/controllers/generic_controller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ void GenericController::Receive()
break;

case phase_t::dataout:
DataOut();
// All data have been transferred
Status();
break;

Expand All @@ -442,36 +442,6 @@ void GenericController::Receive()
}
}

void GenericController::DataOut() const
{
assert(IsDataOut());

switch (GetOpcode()) {
case scsi_command::cmd_write6:
case scsi_command::cmd_write10:
case scsi_command::cmd_write16:
case scsi_command::cmd_write_long10:
case scsi_command::cmd_write_long16:
case scsi_command::cmd_verify10:
case scsi_command::cmd_verify16:
case scsi_command::cmd_mode_select6:
case scsi_command::cmd_mode_select10:
break;

case scsi_command::cmd_set_mcast_addr:
// TODO: Eventually, we should store off the multicast address configuration data here
break;

case scsi_command::cmd_set_iface_mode:
// TODO Should the DaynaPort MAC address actually be set here?
break;

default:
LogWarn(fmt::format("Unexpected Data Out phase for command ${:02x}", static_cast<int>(GetOpcode())));
break;
}
}

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wunused-parameter"
bool GenericController::XferIn(vector<uint8_t> &buf)
Expand Down
1 change: 0 additions & 1 deletion cpp/controllers/generic_controller.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ class GenericController : public AbstractController
void Receive();

void Execute();
void DataOut() const;

virtual void ParseMessage() = 0;
virtual void ProcessMessage() = 0;
Expand Down

0 comments on commit 790ca34

Please sign in to comment.