Update unit tests

uweseimet · Oct 20, 2024 · 9970acf · 9970acf
1 parent d6fc38e
commit 9970acf
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/cpp/test/mocks.h b/cpp/test/mocks.h
@@ -451,7 +451,10 @@ class MockTape : public Tape
 
 public:
 
-    using Tape::Tape;
+    MockTape() : Tape(0)
+    {
+    }
+    ~MockTape() override = default;
 
     void SetReady(bool b)
     {

diff --git a/cpp/test/tape_test.cpp b/cpp/test/tape_test.cpp
@@ -11,7 +11,7 @@
 pair<shared_ptr<MockAbstractController>, shared_ptr<MockTape>> CreateTape()
 {
     auto controller = make_shared<NiceMock<MockAbstractController>>(0);
-    auto tape = make_shared<MockTape>(0);
+    auto tape = make_shared<MockTape>();
     EXPECT_TRUE(tape->Init( { }));
     EXPECT_TRUE(controller->AddDevice(tape));
 
@@ -81,7 +81,7 @@ TEST(TapeTest, Inquiry)
 
 TEST(TapeTest, ValidateFile)
 {
-    MockTape tape(0);
+    MockTape tape;
 
     EXPECT_THROW(tape.ValidateFile(), io_exception)<< "Invalid block count";
 
@@ -106,7 +106,7 @@ TEST(TapeTest, Open)
 
 TEST(TapeTest, Unload)
 {
-    MockTape tape(0);
+    MockTape tape;
 
     tape.SetReady(true);
     EXPECT_TRUE(tape.Eject(false));
@@ -326,7 +326,7 @@ TEST(TapeTest, FormatMedium)
 
 TEST(TapeTest, GetBlockSizes)
 {
-    MockTape tape(0);
+    MockTape tape;
 
     const auto &sizes = tape.GetSupportedBlockSizes();
     EXPECT_EQ(5U, sizes.size());
@@ -341,7 +341,7 @@ TEST(TapeTest, GetBlockSizes)
 TEST(TapeTest, SetUpModePages)
 {
     map<int, vector<byte>> pages;
-    MockTape tape(0);
+    MockTape tape;
 
     // Non changeable
     tape.SetUpModePages(pages, 0x3f, false);