Cover more topics in installation instructions #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cortes-intel
requested review from
Vika-F,
maria-Petrova,
Alexsandruss and
emmwalsh
as code owners
napetrov
reviewed
Sep 30, 2024
INSTALL.md
Outdated
| @@ -19,7 +19,9 @@ | |||
|
|
|||
| Required Software: | |||
| * C/C++ Compiler | |||
| * [DPC++ Compiler](https://www.intel.com/content/www/us/en/developer/tools/oneapi/dpc-compiler.html) | |||
| * [DPC++ Compiler](https://www.intel.com/content/www/us/en/developer/tools/oneapi/dpc-compiler.html) if building with SYCL support | |||
| * Python version 3.7 or higher | |||
There was a problem hiding this comment.
i think 3.7 as well as 3.8 are not officially supported
There was a problem hiding this comment.
Thanks. Updated it to mention version 3.9 or higher.
| * [DPC++ Compiler](https://www.intel.com/content/www/us/en/developer/tools/oneapi/dpc-compiler.html) | ||
| * [DPC++ Compiler](https://www.intel.com/content/www/us/en/developer/tools/oneapi/dpc-compiler.html) if building with SYCL support | ||
| * Python version 3.9 or higher | ||
| * TBB library (repository contains script to download it) |
There was a problem hiding this comment.
there is a tricky thing, that depends on tbb version we must use MKL_FPK_GPU_VERSION_LINE=2024.0. This var controls what layout of tbb will be used. If tbb < 2024.7 its not necessary to use this flag, if higher, its necessary.
We have task for removing it, but its not done yet
There was a problem hiding this comment.
Questions in this regard:
- Isn't the latest version of TBB set at
2021.13.0? - If the build script sources the TBB script that sets the environment variables, would it be possible to retrieve the version from the
.pcfile? Under the default oneapi-basekit install, it should be under/opt/intel/oneapi/tbb/latest/lib/pkgconfig/tbb.pc.
napetrov
approved these changes
Oct 1, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the installation instructions to more accurately reflect the requirements when building from source, and to point at ways of executing the provided examples and unit tests.