-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: adding -fsycl-max-parallel-link-jobs in make #2926
feature: adding -fsycl-max-parallel-link-jobs in make #2926
Conversation
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for reference on whoever looks at this PR in the future: https://www.intel.com/content/www/us/en/docs/dpcpp-cpp-compiler/developer-guide-reference/2024-2/fsycl-max-parallel-link-jobs.html was as of 2024.2 considered an experimental feature that could possibly lead to compilation issues. I think its still fine to include it.
@Alexandr-Solovev can we confirm improvements in link time from CI with this PR? |
its a little bit tricky, because the different machines and active jobs in it, but in local make process the result was: |
Yeah, the problem with public CI is the limitations on cores. When the number of cores are low, this change won't show itself well, because the linking is a smaller fraction of the total time. I would say use the times from private CI. |
we have the same issue in private, like machine specific, some of the machines are faster than others, at least in real scenario(local build) it works and make performance more fine |
/intelci: run |
Description
Adding linking flag to improve linking of onedal_sycl lib in oneDAL