Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper CPUID eax checking #3026

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add proper CPUID eax checking #3026

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4ddec6
Add proper CPUID eax checking
isuruf Dec 17, 2024
7c180fc
remove __daal_serv_cpu_extensions_available and add comments
isuruf Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion cpp/daal/src/services/compiler/generic/env_detect_features.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,19 @@ void run_cpuid(uint32_t eax, uint32_t ecx, uint32_t * abcd)
#endif
}

uint32_t __daal_internal_get_max_extension_support()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is not necessary, it can be folded in below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the pattern of __daal_internal_is_intel_cpu and daal_check_is_intel_cpu where the former is the one that does the work and the latter is there to cache the value in a static variable to avoid running the former multiple times.

{
uint32_t abcd[4];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clearer naming is necessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming used is abcd throughout this file. This variable stores the values of the eax, ebx, ecx, edx registers just like the other functions. Any ideas on what to rename all of them to?

run_cpuid(0x80000000, 0, abcd);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commentary for this would be nice.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments.

return abcd[0];
}

uint32_t daal_get_max_extension_support()
{
static const uint32_t result = __daal_internal_get_max_extension_support();
return result;
}

bool __daal_internal_is_intel_cpu()
{
const uint32_t genu = 0x756e6547, inei = 0x49656e69, ntel = 0x6c65746e;
Expand All @@ -87,6 +100,11 @@ DAAL_EXPORT bool daal_check_is_intel_cpu()

static int check_cpuid(uint32_t eax, uint32_t ecx, int abcd_index, uint32_t mask)
{
if (daal_get_max_extension_support() < eax)
{
// need to check that the eax we run here is supported.
return 0;
}
uint32_t abcd[4];

run_cpuid(eax, ecx, abcd);
Expand Down Expand Up @@ -193,7 +211,7 @@ static int check_sse42_features()

DAAL_EXPORT bool __daal_serv_cpu_extensions_available()
{
return daal_check_is_intel_cpu();
return 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, if a bool, it would be best to return a bool. Secondly, if this is a no-op, then the function should be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the function and its usages.

}

DAAL_EXPORT int __daal_serv_cpu_detect(int enable)
Expand Down
2 changes: 1 addition & 1 deletion cpp/daal/src/services/service_defines.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ DAAL_EXPORT bool daal_check_is_intel_cpu();
#define DAAL_BASE_CPU daal::rv64
#endif

#define DAAL_CHECK_CPU_ENVIRONMENT (daal_check_is_intel_cpu())
#define DAAL_CHECK_CPU_ENVIRONMENT (__daal_serv_cpu_extensions_available())

#if defined(__INTEL_COMPILER)
#define PRAGMA_IVDEP _Pragma("ivdep")
Expand Down