Fix performance issue in __serial_merge
#2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix __serial_merge implementation: using ternary operator / assign operator with SFINAE
SergeyKopienko
requested review from
danhoeflinger,
MikeDvorskiy and
akukanov
…fix __serial_merge implementation: using ternary operator / assign operator with SFINAE
…fix __serial_merge implementation: using ternary operator / assign operator with SFINAE
…fix __serial_merge implementation: using ternary operator / assign operator with SFINAE
…remove __assing_impl function
…optimize condition check sue it's always calculated from left to right
akukanov
reviewed
Jan 27, 2025
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
…rge.h - remove __assing_impl function" - reverted due compile errors in https://github.com/uxlfoundation/oneDPL/actions/runs/12988989427/job/36221124714?pr=2022 oneDPL\include\oneapi\dpl\pstl\hetero\dpcpp\parallel_backend_sycl_merge.h(175,58): error: SYCL kernel cannot call a variadic function 175 | if constexpr (__can_use_ternary_op<_Rng1, _Rng2>().value) | ^ oneDPL\include\oneapi\dpl\pstl\hetero\dpcpp\parallel_backend_sycl_merge.h(350,21): note: called by 'operator()' 350 | __serial_merge(__rng1, __rng2, __rng3, __start.first, __start.second, __i_elem, | ^ include\sycl\handler.hpp(405,7): note: called by 'operator()' 405 | KernelFunc(item); | ^
…fir review comment: additional comments
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
…remove __assing_impl function and fix compile error in __can_use_ternary_op call
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
…ge.h Co-authored-by: Dan Hoeflinger <109972525+danhoeflinger@users.noreply.github.com>
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
…fix review comment
…fix review comment
danhoeflinger
previously approved these changes
Jan 27, 2025
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
danhoeflinger
previously approved these changes
Jan 27, 2025
…apply GitHUB clang format
…fix review comment: let's use real data types
…fix review comment: let's use real data types
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_merge.h
Outdated
Show resolved
Hide resolved
…fix review comment
danhoeflinger
previously approved these changes
Jan 27, 2025
…apply GitHUB clang format
danhoeflinger
approved these changes
Jan 27, 2025
MikeDvorskiy
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second attempt of #2013: the source compile error has been introduced in the PR #1970
Example of the source compile error: https://godbolt.org/z/x6z7GMv1W
In the PR #2013 I detected performance issue.
The goal of this PR - to use ternary operator when it's possible.
Checks on GodBold:
__assing_impl__assing_implThanks to @MikeDvorskiy and @dmitriy-sobolev for their implementations of
__can_use_ternary_op_v!