Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for oneDPL 2022.8.0 #2052

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

timmiesmith
Copy link
Contributor

No description provided.

@timmiesmith timmiesmith added this to the 2022.8.0 milestone Feb 6, 2025
Comment on lines +37 to +40
- ``sort``, ``stable_sort``, ``sort_by_key``, ``stable_sort_by_key``, ``partial_sort_copy`` algorithms
may work incorrectly or cause a segmentation fault when used a device execution policy on a CPU device,
and built on Linux with Intel® oneAPI DPC++/C++ Compiler and -O0 -g compiler options.
To avoid the issue, pass ``-fsycl-device-code-split=per_kernel`` option to the compiler.
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ``sort``, ``stable_sort``, ``sort_by_key``, ``stable_sort_by_key``, ``partial_sort_copy`` algorithms
may work incorrectly or cause a segmentation fault when used a device execution policy on a CPU device,
and built on Linux with Intel® oneAPI DPC++/C++ Compiler and -O0 -g compiler options.
To avoid the issue, pass ``-fsycl-device-code-split=per_kernel`` option to the compiler.
- ``sort``, ``stable_sort``, ``sort_by_key``, ``stable_sort_by_key``, and ``partial_sort_copy`` may work incorrectly or cause a segmentation fault when used with a device execution policy on a CPU device. This issue occurs when the code is built on Linux with the Intel® oneAPI DPC++/C++ Compiler version 2025.0 or earlier, and with the -O0 -g compiler options. To avoid this issue, pass the ``-fsycl-device-code-split=per_kernel`` option to the compiler.

That issue was fixed in Intel® oneAPI DPC++/C++ Compiler 2025.1. I slightly changed the wording since the original first sentence was becoming too long. Linking #2011.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the issue is fixed in the new compiler version but not the old ones, I would move the note to https://uxlfoundation.github.io/oneDPL/introduction.html#known-limitations, to shorten the release notes.

And please split into several lines of reasonable length.

- The ``oneapi::dpl::experimental::ranges::reverse`` algorithm is not available with ``-fno-sycl-unnamed-lambda`` option.
- STL algorithm functions (such as ``std::for_each``) used in DPC++ kernels do not compile with the debug version of
the Microsoft* Visual C++ standard library.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an issue in 2022.4 release, which still exists:

  • esimd::radix_sort and esimd::radix_sort_by_key kernel templates fail to compile when a program
    is built with -g, -O0, -O1 compiler options.

It was fixed in Rolling 2423.32 driver. Linking #1912.

Let's include it here. It still exists, but with older drivers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same story - perhaps better to keep it as a "permanent" limitation rather than in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants