Skip to content

Conversation

@mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Feb 5, 2026

What does this PR change?

mgr-push should not be shipped in the Client Tools for SLE16.
To prevent a submission the easiest was is to disable the build of the package and its dependencies until they are really required on SLE16.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Port(s): Not needed - only master / 5.2 and later thingy

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "frontend_checks"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@mcalmer mcalmer requested a review from meaksh February 5, 2026 13:37
BuildArch: noarch
%endif
%if 0%{?debian} || 0%{?ubuntu}
%if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} >= 1600
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this would prevent mgr-push to build for Tumbleweed, and we ship it as part of TW Client Tools for Uyuni.

I'd consider this instead:

Suggested change
%if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} >= 1600
%if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} == 1600

BuildArch: noarch
%endif
%if 0%{?debian} || 0%{?ubuntu} || 0%{?rhel} >= 8
%if 0%{?debian} || 0%{?ubuntu} || 0%{?rhel} >= 8 || 0%{?suse_version} >= 1600
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same consideration here:

Suggested change
%if 0%{?debian} || 0%{?ubuntu} || 0%{?rhel} >= 8 || 0%{?suse_version} >= 1600
%if 0%{?debian} || 0%{?ubuntu} || 0%{?rhel} >= 8 || 0%{?suse_version} == 1600

BuildRequires: fdupes
BuildRequires: make
%if 0%{?debian} || 0%{?ubuntu}
%if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} >= 1600
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
%if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} >= 1600
%if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} == 1600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants