-
Notifications
You must be signed in to change notification settings - Fork 234
Disable mgr push sle16 #11442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Disable mgr push sle16 #11442
Conversation
| BuildArch: noarch | ||
| %endif | ||
| %if 0%{?debian} || 0%{?ubuntu} | ||
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} >= 1600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this would prevent mgr-push to build for Tumbleweed, and we ship it as part of TW Client Tools for Uyuni.
I'd consider this instead:
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} >= 1600 | |
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} == 1600 |
| BuildArch: noarch | ||
| %endif | ||
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?rhel} >= 8 | ||
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?rhel} >= 8 || 0%{?suse_version} >= 1600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same consideration here:
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?rhel} >= 8 || 0%{?suse_version} >= 1600 | |
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?rhel} >= 8 || 0%{?suse_version} == 1600 |
| BuildRequires: fdupes | ||
| BuildRequires: make | ||
| %if 0%{?debian} || 0%{?ubuntu} | ||
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} >= 1600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} >= 1600 | |
| %if 0%{?debian} || 0%{?ubuntu} || 0%{?suse_version} == 1600 |
What does this PR change?
mgr-push should not be shipped in the Client Tools for SLE16.
To prevent a submission the easiest was is to disable the build of the package and its dependencies until they are really required on SLE16.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Links
Port(s): Not needed - only master / 5.2 and later thingy
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!