-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uyuni Health Check Tool Disconnected Solution #9322
Draft
ycedres
wants to merge
54
commits into
master
Choose a base branch
from
health-check-skeleton
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point the completion-checker script just processes .log files and not compressed files as it seems that the information in the positions.yaml file is not the number of bytes for the .tar.gz file but instead, the number of lines in the logfile inside the .tar.gz. This breaks the logic of the completion-checker so this is a partial solution at this moment.
agraul
reviewed
Dec 10, 2024
agraul
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few questions inline. I think we should enable the linter as soon as we can, it will be a bit of work to bring the code up to our standards (as expected for PoC code)
health-check/src/uyuni_health_check/containers/exporter/Dockerfile
Outdated
Show resolved
Hide resolved
health-check/src/uyuni_health_check/containers/grafana/Containerfile
Outdated
Show resolved
Hide resolved
health-check/src/uyuni_health_check/containers/logcli/Dockerfile
Outdated
Show resolved
Hide resolved
agraul
reviewed
Dec 11, 2024
agraul
reviewed
Dec 11, 2024
Remaining tasks:
|
As this waiting mechanism is not working we remove it and also remove unused code that was intended to achieve something similar for Loki.
Adjust promtail container exec script
[health-check] Move sources to python dir
[health-check] rename execution scripts
Remove references to Uyuni on CLI executions
…ra-fixes [health-check] fix performance issue and add extra enhacements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT
What does this PR change?
Initial implementation of the Disconnected solution. No access to an Uyuni server or existing monitoring stack, only access to a supportconfig.
See: https://github.com/uyuni-project/uyuni-rfc/blob/master/accepted/00101-health-check-tool.md
GUI diff
No difference.
Before:
After:
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
API documentation added: please review the Wiki page Writing Documentation for the API if you have any changes to API documentation.
(OPTIONAL) Documentation PR
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE
Links
Issue(s): #
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!