Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSv3 - Fix search and sorting for the peripherals list #9869

Open
wants to merge 5 commits into
base: issv3-2
Choose a base branch
from

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented Feb 28, 2025

What does this PR change?

This PR fixes the search and the sorting that are currently not working in the peripheral list.

GUI diff

Filtering and sorting now works

  • DONE

Documentation

  • Documentation WIP TBD

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9869/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9869/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@mackdk mackdk removed the request for review from a team February 28, 2025 15:22
@mackdk mackdk force-pushed the issv3-fix-peripheral-list-search branch from 043e85f to e71f537 Compare February 28, 2025 15:33
@mackdk mackdk force-pushed the issv3-fix-peripheral-list-search branch from e71f537 to 19e03c5 Compare February 28, 2025 15:35
searchField={<SearchField filter={this.searchData} placeholder={t("Filter by FQDN")} />}
>
<Column columnKey="fqdn" comparator={Utils.sortByText} header={t("Peripheral FQDN")} cell={(row) => row.fqdn} />
<Column
columnKey="nChannelsSync"
comparator={Utils.sortByNumber}
sortable={false}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the default value, so setting it should not be necessary if I'm not mistaken.

@mackdk mackdk closed this Mar 3, 2025
@mackdk mackdk deleted the issv3-fix-peripheral-list-search branch March 3, 2025 09:57
@mackdk mackdk restored the issv3-fix-peripheral-list-search branch March 3, 2025 09:58
@mackdk mackdk reopened this Mar 3, 2025
@mackdk mackdk requested review from mcalmer and CDellaGiusta March 3, 2025 11:13
Copy link
Contributor

@CDellaGiusta CDellaGiusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (java part, I have no knowledge of typescript)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants