-
Notifications
You must be signed in to change notification settings - Fork 49
Update TestFlight release channel from internal to public beta #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- 更新 Fastfile 配置以支持公测 - 添加 "Public Beta" 测试组 - 增加更详细的 beta_app_review_info 配置 - 添加中文描述和说明 - 确保 distribute_external 设置为 true - 更新 GitHub Actions workflow 描述 - 明确标注为 Public Beta 发布 - 添加外部测试者邮件通知说明 - 配置改进 - 添加 beta_app_description - 添加 demo_account_required: false - 更新联系电话格式 现在版本发布将自动提交到 TestFlight 公测,外部测试者将收到邮件通知。 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the Release Pipeline configuration to change TestFlight distribution from internal testing to public beta, allowing broader user participation in testing.
- Added Chinese localization for beta review information and notifications
- Updated testing groups to include "Public Beta" and expanded group coverage
- Enhanced GitHub Actions workflow messaging to reflect public beta distribution
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
fastlane/Fastfile | Added Chinese beta app descriptions, updated contact info, and expanded testing groups for public beta |
.github/workflows/release.yml | Updated job names and GitHub release notes to reflect public beta distribution |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fastlane/Fastfile
Outdated
demo_account_name: "", | ||
demo_account_password: "", | ||
notes: "This is a V2EX forum client app. No special account needed for testing." | ||
notes: "这是一个 V2EX 论坛的第三方客户端应用,测试不需要特殊账号。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The beta review notes are now in Chinese, but Apple's App Store Connect interface and review process are primarily in English. Consider providing English notes for beta_app_review_info to ensure clear communication with Apple reviewers.
notes: "这是一个 V2EX 论坛的第三方客户端应用,测试不需要特殊账号。" | |
notes: "This is a third-party client app for the V2EX forum. No special account is required for testing." |
Copilot uses AI. Check for mistakes.
fastlane/Fastfile
Outdated
contact_first_name: "V2er", | ||
contact_last_name: "Support", | ||
contact_phone: "+1234567890", | ||
contact_phone: "+86 1234567890", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contact phone number appears to be a placeholder (1234567890). This should be replaced with a valid phone number for Apple's beta review process.
contact_phone: "+86 1234567890", | |
contact_phone: "+86 13800138000", |
Copilot uses AI. Check for mistakes.
fastlane/Fastfile
Outdated
submit_beta_review: true, | ||
submit_beta_review: true, # 自动提交Beta审核 | ||
wait_for_uploaded_build: true, | ||
beta_app_description: "V2er 是一个优雅的 V2EX 第三方客户端", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The beta_app_description is in Chinese, but TestFlight's public beta audience may include international users. Consider providing an English description or adding both languages for broader accessibility.
beta_app_description: "V2er 是一个优雅的 V2EX 第三方客户端", | |
beta_app_description: "V2er is an elegant third-party client for V2EX.\nV2er 是一个优雅的 V2EX 第三方客户端", |
Copilot uses AI. Check for mistakes.
fastlane/Fastfile
Outdated
contact_phone: "+86 1234567890", | ||
demo_account_name: "", | ||
demo_account_password: "", | ||
notes: "这是一个 V2EX 论坛的第三方客户端应用,测试不需要特殊账号。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a duplicate of the issue found on line 97. The beta review notes are in Chinese but should be in English for Apple reviewers.
notes: "这是一个 V2EX 论坛的第三方客户端应用,测试不需要特殊账号。" | |
notes: "This is a third-party client app for the V2EX forum. No special account is required for testing." |
Copilot uses AI. Check for mistakes.
Code Coverage Report ❌Current coverage: 0% |
- Updated all Chinese comments to English - Fixed beta app description to English - Fixed notes in beta_app_review_info to English - Maintains consistency with English codebase 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Code Coverage Report ❌Current coverage: 0% |
beta_app_feedback_email: "support@v2er.app", | ||
demo_account_required: false, # No demo account required | ||
beta_app_review_info: { | ||
contact_email: "support@v2er.app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demo_account_required: false, # No demo account required | ||
beta_app_review_info: { | ||
contact_email: "support@v2er.app", | ||
contact_first_name: "V2er", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete these fields if they're optional
submit_beta_review: true # Automatically submit for beta review if needed | ||
submit_beta_review: true, # Automatically submit for Beta review | ||
beta_app_description: "V2er is an elegant third-party client for V2EX forum", | ||
beta_app_feedback_email: "support@v2er.app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete if it's optional
- Removed empty demo_account_name and demo_account_password fields (optional) - Updated placeholder phone number to a more realistic format - Kept English descriptions and notes for Apple reviewers Addresses review comments from PR #44 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
groups: ["External"], # Default external tester group | ||
notify_external_testers: true, | ||
distribute_external: true, # Distribute to external testers (public beta) | ||
groups: ["Public Beta", "External Testers", "Beta Testers"], # Public beta groups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The groups array contains multiple similar group names that may not all exist in TestFlight. Consider using only the groups that actually exist in your TestFlight configuration to avoid potential distribution failures. If unsure, start with a single known group name like 'Public Beta'.
groups: ["Public Beta", "External Testers", "Beta Testers"], # Public beta groups | |
groups: ["Public Beta"], # Use only a single known group to avoid distribution failures |
Copilot uses AI. Check for mistakes.
distribute_external: true, # Distribute to external testers (public beta) | ||
distribute_only: false, # Upload and distribute in one action | ||
groups: ["External Testers", "Beta Testers"], # Try common group names | ||
groups: ["Public Beta", "External Testers", "Beta Testers"], # Public beta groups |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplicates the same group configuration from lines 82. The groups array contains multiple similar group names that may not all exist in TestFlight. Consider using only the groups that actually exist in your TestFlight configuration to avoid potential distribution failures.
groups: ["Public Beta", "External Testers", "Beta Testers"], # Public beta groups | |
groups: ["Public Beta"], # Only include groups that exist in TestFlight |
Copilot uses AI. Check for mistakes.
Code Coverage Report ❌Current coverage: 0% |
Overview
Update Release Pipeline configuration to change TestFlight distribution from internal testing to public beta testing, allowing more users to participate in testing.
Changes
Fastfile Configuration Updates
distribute_external: true
is enabled (distribute to external testers)demo_account_required: false
(no demo account needed)notify_external_testers: true
GitHub Actions Workflow Updates
Impact
Test Plan
🤖 Generated with Claude Code