Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace popup component with popover component #42

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

paodb
Copy link
Collaborator

@paodb paodb commented Dec 4, 2024

Close #41.

This PR includes changes made in #40.

As replacing the popup component by using popover component is a breaking change, version was updated to 5.0.0-SNAPSHOT.

blackbluegl and others added 2 commits December 4, 2024 12:21
Update Vaadin version to 24.5.6.
Version set to 5.0.0-SNAPSHOT.
Dependency of jakarta.validation.constraints.NotNull removed.
Update access modifiers to allow to extend functionality.
Code cleanup.
@paodb paodb requested a review from mlopezFC December 4, 2024 17:04
Copy link
Contributor

@mlopezFC mlopezFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlopezFC mlopezFC merged commit 0fcbf47 into main Dec 4, 2024
1 check failed
@mlopezFC mlopezFC deleted the popup-replacement branch December 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Popup add-on with new Popover core component
3 participants