Release 0.19.1 ready (#517)

* #508 likely done (#509) * #54 Swedish translation to superdatepickeri18n.properties (#507) (#510) * #511 done (#512) * #513 #514 done (#515) * (bot) release notes updated for 0.19.1 * (bot) version updated to 0.19.1 --------- Co-authored-by: Sebastian Penttinen <31658152+sebastianpenttinen@users.noreply.github.com> Co-authored-by: sebastianPenttinen <sebastian.penttinen@beanbakers.fi>
vaadin-miki · Jul 15, 2024 · e2ee389 · e2ee389
1 parent 6d56022
commit e2ee389
Show file tree

Hide file tree

Showing 16 changed files with 335 additions and 307 deletions.
diff --git a/README.md b/README.md
@@ -27,7 +27,7 @@ This is the relevant dependency:
 <dependency>
    <groupId>pl.unforgiven</groupId>
    <artifactId>superfields</artifactId>
-   <version>0.19.0</version>
+   <version>0.19.1</version>
 </dependency>
 ```
 
@@ -65,10 +65,11 @@ The author of the majority of the code is me (Miki), but this project would not
 * Simon Martinelli
 * Dmitry Nazukin
 * Stefan Penndorf
+* Sebastian Penttinen
 * Stuart Robinson
 * Kaspar Scherrer
 * Tomi Virkki
-* Martin Vysny
+* Martin Vyšný
 * Leif Åstrand
 
 ## Support

diff --git a/demo-v24/pom.xml b/demo-v24/pom.xml
@@ -4,11 +4,11 @@
     <parent>
         <artifactId>superfields-parent</artifactId>
         <groupId>pl.unforgiven</groupId>
-        <version>0.19.0</version>
+        <version>0.19.1</version>
     </parent>
 
     <artifactId>superfields-demo-v24</artifactId>
-    <version>0.19.0</version>
+    <version>0.19.1</version>
     <name>V24+ demo app for SuperFields</name>
     <description>Showcase application for V24+ and SuperFields.</description>
     <packaging>war</packaging>
@@ -22,7 +22,7 @@
         <dependency>
             <groupId>pl.unforgiven</groupId>
             <artifactId>superfields</artifactId>
-            <version>0.19.0</version>
+            <version>0.19.1</version>
         </dependency>
         <dependency>
             <groupId>jakarta.servlet</groupId>
@@ -136,11 +136,11 @@
                                     <goal>build-frontend</goal>
                                 </goals>
                                 <phase>compile</phase>
+                                <configuration>
+                                    <optimizeBundle>false</optimizeBundle>
+                                </configuration>
                             </execution>
                         </executions>
-                        <configuration>
-                            <productionMode>true</productionMode>
-                        </configuration>
                     </plugin>
                 </plugins>
             </build>

diff --git a/demo-v24/src/main/java/org/vaadin/miki/InfoPage.java b/demo-v24/src/main/java/org/vaadin/miki/InfoPage.java
@@ -16,7 +16,7 @@
 
 import java.io.IOException;
 import java.io.InputStream;
-import java.util.Locale;
+import java.util.Collection;
 
 /**
  * Information about the demo, its organisation and components.
@@ -37,12 +37,14 @@ public InfoPage() {
             new Span("Bottom left corner of the browser window will show major notifications from each component - like value change notifications. Bottom right corner is reserved for secondary notifications, e.g. focus and blur events.")
         );
 
+        final Collection<Class<? extends Component>> types = DemoComponentFactory.get().getDemoableComponentTypes();
         final ItemGrid<Class<? extends Component>> grid = new ItemGrid<Class<? extends Component>>()
-                .withItems(DemoComponentFactory.get().getDemoableComponentTypes())
+                .withItems(types)
                 .withColumnCount(5)
                 .withPaddingCellsClickable(false)
                 .withCellGenerator(this::buildDisplayCell)
-                .withId("presentation-grid");
+                .withId("presentation-grid")
+                .withLabel("There are %d components with demo pages:".formatted(types.size()));
         grid.addValueChangeListener(event -> this.getUI()
                 .ifPresent(ui ->
                         ui.navigate(
@@ -65,16 +67,14 @@ private Component buildDisplayCell(Class<? extends Component> type, int row, int
         final Div result = new Div();
         result.add(new H3(type.getSimpleName()));
 
-        try (InputStream resource = this.getClass().getClassLoader().getResourceAsStream(type.getSimpleName().toLowerCase(Locale.ROOT) + ".md")) {
+        final String resourceName = "/" + type.getSimpleName() + ".md";
+        try (InputStream resource = this.getClass().getClassLoader().getResourceAsStream(resourceName)) {
             if (resource != null) {
-                try {
                     final Span desc = new Span(new String(resource.readAllBytes()));
                     desc.addClassName("presentation-description");
                     result.add(desc);
-                } catch (IOException e) {
-                    LOGGER.error("could not read description for component {}", type.getSimpleName(), e);
-                }
             }
+            else LOGGER.error("did not find resource {}", resourceName);
         } catch (IOException e) {
             LOGGER.error("could not open description for component {}", type.getSimpleName(), e);
         }

diff --git a/pom.xml b/pom.xml
@@ -1,22 +1,24 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
     <groupId>pl.unforgiven</groupId>
     <artifactId>superfields-parent</artifactId>
-    <version>0.19.0</version>
+    <version>0.19.1</version>
     <modules>
         <module>superfields</module>
         <module>demo-v24</module>
     </modules>
     <name>SuperFields - Root project for SuperFields</name>
-    <description>Root project for SuperFields. Includes basic dependencies, repositories and other configuration.</description>
+    <description>Root project for SuperFields. Includes basic dependencies, repositories and other configuration.
+    </description>
     <packaging>pom</packaging>
 
     <properties>
         <maven.compiler.source>17</maven.compiler.source>
         <maven.compiler.target>17</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <vaadin.version>24.3.0</vaadin.version>
+        <vaadin.version>24.3.12</vaadin.version>
     </properties>
 
 </project>
diff --git a/superfields/pom.xml b/superfields/pom.xml
@@ -9,13 +9,13 @@
     <name>SuperFields</name>
     <description>Code for various Vaadin 24 fields and other components.</description>
     <url>https://www.unforgiven.pl/superfields</url>
-    <version>0.19.0</version>
+    <version>0.19.1</version>
 
     <properties>
         <maven.compiler.source>17</maven.compiler.source>
         <maven.compiler.target>17</maven.compiler.target>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <vaadin.version>24.3.0</vaadin.version>
+        <vaadin.version>24.3.12</vaadin.version>
         <maven.jar.plugin.version>3.1.2</maven.jar.plugin.version>
         <javadoc.plugin.version>3.4.1</javadoc.plugin.version>
     </properties>

diff --git a/superfields/release-notes.md b/superfields/release-notes.md
@@ -1,3 +1,11 @@
+# 0.19.1 - Bug fixes
+## New features and enhancements
+(nothing reported)
+## Changes to API
+* \#514 - [Upgrade Vaadin to 24.3.12](https://github.com/vaadin-miki/super-fields/issues/514)
+## Bug fixes
+* \#511 - [AFTER_* label positions are incorrect for custom fields](https://github.com/vaadin-miki/super-fields/issues/511)
+* \#513 - [SuperTextField.inputMode cannot be set inside a Grid.Column](https://github.com/vaadin-miki/super-fields/issues/513)
 # 0.19.0 - Component(Multi)Select and refreshed LazyLoad
 ## New features and enhancements
 * \#488 - [ComponentSelect (and ButtonSelect as an example)](https://github.com/vaadin-miki/super-fields/issues/488)

diff --git a/superfields/src/main/java/org/vaadin/miki/superfields/collections/MapField.java b/superfields/src/main/java/org/vaadin/miki/superfields/collections/MapField.java
@@ -37,7 +37,7 @@
  * @author miki
  * @since 2022-04-08
  */
-@CssImport(value = "./styles/label-positions.css", themeFor = "vaadin-custom-field")
+@CssImport(value = "./styles/label-positions.css", themeFor = "map-field")
 @Tag("map-field")
 @JsModule("./map-field.js")
 public class MapField<K, V> extends CustomField<Map<K, V>> implements HasStyle,

diff --git a/superfields/src/main/java/org/vaadin/miki/superfields/object/ObjectField.java b/superfields/src/main/java/org/vaadin/miki/superfields/object/ObjectField.java
@@ -51,7 +51,7 @@
  * @author miki
  * @since 2022-05-16
  */
-@CssImport(value = "./styles/label-positions.css", themeFor = "vaadin-custom-field")
+@CssImport(value = "./styles/label-positions.css", themeFor = "object-field")
 @Tag("object-field")
 @JsModule("./object-field.js")
 public class ObjectField<T> extends CustomField<T>

diff --git a/superfields/src/main/java/org/vaadin/miki/superfields/text/LabelField.java b/superfields/src/main/java/org/vaadin/miki/superfields/text/LabelField.java
@@ -24,7 +24,7 @@
  * @author miki
  * @since 2022-04-08
  */
-@CssImport(value = "./styles/label-positions.css", themeFor = "vaadin-custom-field")
+@CssImport(value = "./styles/label-positions.css", themeFor = "label-field")
 @Tag("label-field")
 @JsModule("./label-field.js")
 public class LabelField<V> extends CustomField<V> implements HasStyle, WithLabelMixin<LabelField<V>>,