Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visibility of getViewBean and parseViewName to protected #219

Merged
merged 2 commits into from
Oct 10, 2017

Conversation

tsuoanttila
Copy link
Contributor

@tsuoanttila tsuoanttila commented Oct 10, 2017

Addresses #98


This change is Reviewable

@hesara
Copy link
Contributor

hesara commented Oct 10, 2017

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.


vaadin-cdi/src/main/java/com/vaadin/cdi/CDIViewProvider.java, line 66 at r1 (raw file):

    private transient CreationalContext<?> currentViewCreationalContext;

    public final static class ViewChangeListenerImpl

(unnecessary formatting changes)


vaadin-cdi/src/main/java/com/vaadin/cdi/CDIViewProvider.java, line 328 at r1 (raw file):

    /**
     * 

missing parts of javadoc


Comments from Reviewable

@hesara
Copy link
Contributor

hesara commented Oct 10, 2017

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@hesara hesara merged commit c96d888 into 1.0 Oct 10, 2017
@hesara hesara deleted the 98_cdiviewprovider_apis branch October 10, 2017 10:12
@hesara hesara added this to the Vaadin CDI 1.0.4 milestone Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants