docs: remove inline renderer usage from React component examples #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
sissbruecker
removed
the
Language unchecked
sissbruecker
commented
Feb 14, 2025
| @@ -20,15 +20,15 @@ function Example() { | |||
| { name: 'Financials.xlsx', size: '42 MB' }, | |||
| ]); | |||
|
|
|||
| const renderMenuBar = useCallback(() => <MenuBar items={items.value} theme="tertiary" />, []); | |||
There was a problem hiding this comment.
Renderers that use state need to be within the component function and be memoized to only be created once.
I made some exceptions on this by putting renderers that don't use state into the component where it provides context to the code snippet.
web-padawan
approved these changes
Feb 14, 2025
frontend/demo/component/combobox/react/combo-box-presentation.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes vaadin/react-components#294