fix: Make Flow Grid compatible with ASM versions older than 9 #4615
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow-components/4615.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/vaadin/flow-components/4615.diff | git applyOnce you're satisfied commit and push your changes in your project. Footnotes |
vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
Outdated
Show resolved
Hide resolved
mshabarov
changed the title
vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
Outdated
Show resolved
Hide resolved
| protected abstract <T> GridSelectionModel<T> createModel(Grid<T> grid); | ||
| protected <T> GridSelectionModel<T> createModel(Grid<T> grid) { | ||
| return switch (this) { | ||
| case SINGLE -> new AbstractGridSingleSelectionModel<T>(grid) { |
There was a problem hiding this comment.
Just thinking out load: are you sure the oldish ASM can work with this newish switch? 😬
There was a problem hiding this comment.
Good catch! But believe or not, this new switch doesn't trigger any errors in Payara, application starts fine 😅 don't ask me why :)
|
We need this before releasing 24.0 beta. |
|
SonarCloud Quality Gate failed.
|
Solution for vaadin/flow#15625, until payara/Payara#6127 is fixed.