Skip to content

Conversation

@claytongulick
Copy link

@claytongulick claytongulick commented Mar 29, 2023

Description

This is a simple addition to optionally enable the new View Transition API

Fixes #841

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lozandier
Copy link

@claytongulick Have the historical reviewers of this repo such as @platosha and @jouni ever contacted you to review this CL to merge this in?

If not, it may make sense for a friendly ping to @vursen and other contributors to vaadin's Web component repository that had commits as recent as last week

@jouni
Copy link
Member

jouni commented Jul 2, 2024

Looks nice in general (didn't read the code in detail) 👍 Shame on us for not handling this PR in a timely manner.

Note, though, that Vaadin has recently moved over to using React Router (in Vaadin 24.4), so this enhancement/feature won't have an impact on new Vaadin apps. React Router has preliminary support for native view transitions: https://reactrouter.com/en/main/hooks/use-view-transition-state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable native View Transition API

4 participants