fix: add Signals support for unit tests with controllable task flushing #2042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a test-only TestSignalEnvironment that captures all Signals-related tasks when no VaadinSession/VaadinService is available (e.g., background threads). Tests can deterministically flush these tasks via new runPendingSignalsTasks helpers in BaseUIUnitTest. Fixes #1968
mcollovati
force-pushed
the
issues/1968-signals
branch
from
119a056 to
dd858d0
Compare
|
|
|
Component effect is IMO better to set up outside of the background task, as it's more like an "initialization static" code to be run once. I did a small refactoring here b7df31c, it gives a bit more boilerplate code but make these 3 cases independent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a test-only TestSignalEnvironment that captures all Signals-related tasks when no VaadinSession/VaadinService is available (e.g., background threads).
Tests can deterministically flush these tasks via new runPendingSignalsTasks helpers in BaseUIUnitTest.
Fixes #1968